-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add missing openai.fm model names to TTSModelSettings.voice
type
#269
base: main
Are you sure you want to change the base?
Conversation
looks like tests are failing? |
Thanks for your review! @rm-openai I realized that I omitted some details in the description. To clarify, the changes work together with the related PR in openai-python(deps repo) as follows:
Please note that first, the addition of the model type on the openai-python side must be completed. After that, when openai-agents-python uses the updated version (step 2), there is a concern that the typecheck might still fail. I appreciate your attention to this matter! |
Makes sense. I think we should probably update this param in the agents SDK to be a |
That makes sense. However, even with the parameter updated to suggestion here: voice=settings.voice or DEFAULT_VOICE, # type: ignore |
yes, we'll be updating the openai SDK soon |
be60a73
to
83700ad
Compare
It seems that the dependency on |
changes
Include two missing model names (
ballad
,verse
) from openai.fm in the voice type definition to ensure coverage of all TTS voices.Note that a simultaneous update of the dependency module is required for full compatibility—this is the reason why tests are failing.
https://github.com/openai/openai-python/blob/6d0ecdd8ecbface903cf93c7571398b90b803b0b/src/openai/resources/audio/speech.py#L56