feat: Add strict_mode option to function_schema and function_tool #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @codefromthecrypt, I used your suggested edge cases (e.g., multiple optional parameters of different types) as inspiration for the test cases in this PR. Thanks for the great examples! Let me know if you have any additional suggestions or feedback. |
|
Hey @rm-openai, I've implemented the strict_mode option for |
codefromthecrypt
approved these changes
Mar 12, 2025
Co-authored-by: Adrian Cole <[email protected]>
Jai0401
force-pushed
the
enhancement/function_tool-strict-mode
branch
from
197abec to
0c33a24
Compare
rm-openai
approved these changes
Mar 16, 2025
|
@rm-openai if you don't mind cutting a release by weds, that would be great. I'm using this as a demo at the red hat user group in Cary, NC thursday https://www.meetup.com/raleigh-rhug/events/306421516/?eventOrigin=group_upcoming_events |
nakasy000
pushed a commit
to nakasy000/openai-agents-python
that referenced
this pull request
Mar 27, 2025
…enai#60) This PR introduces a `strict_mode: bool = True` option to `@function_tool`, allowing optional parameters when set to False. This change enables more flexibility while maintaining strict JSON schema validation by default. resolves openai#43 ## Changes: - Added `strict_mode` parameter to `@function_tool` and passed it to `function_schema` and `FunctionTool`. - Updated `function_schema.py` to respect `strict_mode` and allow optional parameters when set to False. - Added unit tests to verify optional parameters work correctly, including multiple optional params with different types. ## Tests: - Verified function calls with missing optional parameters behave as expected. - Added async tests to validate behavior under different configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
strict_mode: bool = Trueoption to@function_tool, allowing optional parameters when set to False. This change enables more flexibility while maintaining strict JSON schema validation by default.resolves #43
Changes:
strict_modeparameter to@function_tooland passed it tofunction_schemaandFunctionTool.function_schema.pyto respectstrict_modeand allow optional parameters when set to False.Tests: