-
Notifications
You must be signed in to change notification settings - Fork 11.9k
Create wheather using js #2338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Create wheather using js #2338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -0,0 +1,100 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relocate and rename the new example file
The new content is added at the repository root with a space-containing filename and no extension, which violates the repo guideline to place runnable examples under examples/<topic>/ with lowercase dash/underscore names; this makes the example hard to discover and inconsistent with the cookbook’s structure, so it should be moved into an appropriate examples/<topic>/ folder with a descriptive .html (or .md) filename.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,100 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add registry metadata for the new content
This commit introduces a new piece of content but does not add a corresponding entry in registry.yaml, which is required for new content to appear on cookbook.openai.com per the repo guidelines; please register the new example with a path, date, and tags so it is included in the site build.
Useful? React with 👍 / 👎.
| </div> | ||
|
|
||
| <script> | ||
| const apiKey = "YOUR_API_KEY"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid hard-coding API keys in the example
The example hard-codes apiKey as a string literal, which encourages users to paste real secrets directly into source files; the repo guidelines require documenting required environment variables instead of embedding keys, so this should be switched to a documented configuration mechanism (or clearly gated placeholder) to avoid accidental key exposure.
Useful? React with 👍 / 👎.
Summary
Briefly describe the changes and the goal of this PR. Make sure the PR title summarizes the changes effectively.
Motivation
Why are these changes necessary? How do they improve the cookbook?
For new content
When contributing new content, read through our contribution guidelines, and mark the following action items as completed:
We will rate each of these areas on a scale from 1 to 4, and will only accept contributions that score 3 or higher on all areas. Refer to our contribution guidelines for more details.