Skip to content

fix(pydantic v1): more robust ModelField.annotation check #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2025
Merged

fix(pydantic v1): more robust ModelField.annotation check #2163

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d9a9f4
made pydantic change
Nov 20, 2024
d83221b
Merge remote-tracking branch 'origin/main'
Konnor-Young Mar 5, 2025
6fa9330
updated _models line 655 to prevent ModelInput error
Konnor-Young Mar 5, 2025
5796b24
updated _models line 655 to prevent ModelInput error
Konnor-Young Mar 5, 2025
ab8707b
Merge branch 'main' into main
Konnor-Young Mar 6, 2025
1527e23
Merge branch 'main' into main
RobertCraigie Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/openai/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,8 +651,8 @@ def _build_discriminated_union_meta(*, union: type, meta_annotations: tuple[Any,
# Note: if one variant defines an alias then they all should
discriminator_alias = field_info.alias

if field_info.annotation and is_literal_type(field_info.annotation):
for entry in get_args(field_info.annotation):
if (annotation := getattr(field_info, 'annotation', None)) and is_literal_type(annotation):
for entry in get_args(annotation):
if isinstance(entry, str):
mapping[entry] = variant

Expand Down
Loading