-
-
Notifications
You must be signed in to change notification settings - Fork 227
None
is not correctly serialized for certain optional query params
#380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
None
is not correctly serialized for optional query paramsNone
is not correctly serialized for certain optional query params
dbanty
added a commit
that referenced
this issue
Aug 2, 2021
…tional query params [#421, #380]. Thanks @forest-benchling!
dbanty
added a commit
that referenced
this issue
Aug 7, 2021
…tional query params [#421, #380]. Thanks @forest-benchling!
dbanty
added a commit
that referenced
this issue
Aug 15, 2021
…tional query params [#421, #380]. Thanks @forest-benchling!
dbanty
added a commit
that referenced
this issue
Aug 15, 2021
…tional query params [#421, #380]. Thanks @forest-benchling!
dbanty
added a commit
that referenced
this issue
Aug 15, 2021
…tional query params [#421, #380]. Thanks @forest-benchling!
dbanty
added a commit
that referenced
this issue
Aug 15, 2021
…tional query params [#421, #380, #462]. Thanks @forest-benchling!
Resolved in 0.10.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In #331, we decided to allow
None
to be passed in optional query params and treated identically toUNSET
.However, a few cases weren't supported:
I haven't done an exhaustive search so there may be others as well; potentially any types that require non-trivial JSON serialization.
To Reproduce
This can already be seen in
end_to_end_tests/golden-record/my_test_api_client/api/tests/defaults_tests_defaults_post.py:90
, which will crash ifNone
is passed in for the model.Expected behavior
For all types, if the query param is optional,
None
is treated asUNSET
.OpenAPI Spec File
The existing
openapi.json
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: