Skip to content

feat: Include both UNSET and None static types for nullable or optional query params #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2021

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Aug 2, 2021

Based on #421 by @forest-benchling. Includes a bit of refactor in e2e tests as I slowly work toward organizing them a bit better.

Closes #421, #380.

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #462 (486f5ae) into main (53cdd94) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 486f5ae differs from pull request most recent head 2484efe. Consider uploading reports for the commit 2484efe to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #462   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1592      1591    -1     
=========================================
- Hits          1592      1591    -1     
Impacted Files Coverage Δ
openapi_python_client/parser/openapi.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53cdd94...2484efe. Read the comment docs.

Copy link
Collaborator

@forest-benchling forest-benchling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works for Benchling, and much cleaner than the earlier approaches. Thanks Dylan!

@dbanty
Copy link
Collaborator Author

dbanty commented Aug 7, 2021

@forest-benchling I swapped out the strings in the new e2e test for datetimes instead so we can see serialization.

@dbanty dbanty force-pushed the query-params-optional-types branch 2 times, most recently from c91bd92 to 8b68c10 Compare August 15, 2021 16:52
@dbanty dbanty force-pushed the query-params-optional-types branch from 8b68c10 to 2484efe Compare August 15, 2021 17:22
@dbanty
Copy link
Collaborator Author

dbanty commented Aug 15, 2021

Refactored a bit of tests in here to make resolving conflicts with main easier.

@dbanty dbanty merged commit c5293bf into main Aug 15, 2021
@dbanty dbanty deleted the query-params-optional-types branch August 15, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants