Enumerate duplicate model names #1212
Open
+61
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses: #652
Even with
use_path_prefixes_for_title_model_namesset totrue, duplicate model class names can occur. By default, when duplicates are encountered they will be skipped. This can cause error when they are referenced later.This PR enables setting
enumerate_duplicate_model_namestotrue(falseby default) in the config file which will result in a number being added to duplicate names starting with 1. For instance, if there are multiple occurrences in the schema ofMyModelName, the initial occurrence will remainMyModelNameand subsequent occurrences will be namedMyModelName1,MyModelName2and so on.The existing
test_model_name_conflicttest is updated to account for this new config option.