Skip to content

Support non-file fields in Multipart requests #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

csymeonides-mf
Copy link
Contributor

@csymeonides-mf csymeonides-mf commented Mar 19, 2021

Closes #351

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #353 (6ab135f) into main (339d768) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1420      1420           
=========================================
  Hits          1420      1420           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 339d768...6ab135f. Read the comment docs.

@csymeonides-mf csymeonides-mf force-pushed the feat-multipart-non-file-fields branch from 14a9161 to ef63169 Compare March 19, 2021 21:54
@csymeonides-mf csymeonides-mf changed the title Feat multipart non file fields Support non-file fields in Multipart requests Mar 19, 2021
@csymeonides-mf csymeonides-mf force-pushed the feat-multipart-non-file-fields branch 3 times, most recently from b2e8e7d to 2a9cf87 Compare March 19, 2021 22:24
@csymeonides-mf csymeonides-mf marked this pull request as ready for review March 19, 2021 22:36
@csymeonides-mf
Copy link
Contributor Author

@dbanty I have tested this locally against a real server, not sure what other tests I could have added to this repo though?

@csymeonides-mf csymeonides-mf force-pushed the feat-multipart-non-file-fields branch from 2a9cf87 to 6ab135f Compare March 20, 2021 18:09
@dbanty
Copy link
Collaborator

dbanty commented Mar 20, 2021

@csymeonides-mf thanks for both reporting this issue and providing a fix! I tweaked it a bit to reduce the extra generated code over in #355. Will you take a look at that and make sure it's still solving you problem?

@csymeonides-mf
Copy link
Contributor Author

Yes thanks, that looks great! I wasn't sure if form and multipart are mutually exclusive, but I think it's a safe assumption.

@csymeonides-mf csymeonides-mf deleted the feat-multipart-non-file-fields branch March 20, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support non-file fields in Multipart requests
2 participants