Skip to content

fix: Errors in allOf behaviour #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2021

Conversation

csymeonides-mf
Copy link
Contributor

I discovered some issues with the handling of allOf, this should fix them!

@csymeonides-mf
Copy link
Contributor Author

Fixing the e2e errors now...

@csymeonides-mf csymeonides-mf force-pushed the fix-allof-behaviour branch 2 times, most recently from 62956c6 to e2d3094 Compare March 26, 2021 21:57
@csymeonides-mf csymeonides-mf changed the title Fix allof behaviour fix: Errors in allOf behaviour Mar 26, 2021
@csymeonides-mf csymeonides-mf force-pushed the fix-allof-behaviour branch 2 times, most recently from 3d33a68 to efa5e95 Compare March 26, 2021 23:01
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #363 (3dce9aa) into main (caf6814) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #363   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         1508      1521   +13     
=========================================
+ Hits          1508      1521   +13     
Impacted Files Coverage Δ
...penapi_python_client/parser/properties/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf6814...3dce9aa. Read the comment docs.

@csymeonides-mf csymeonides-mf force-pushed the fix-allof-behaviour branch 2 times, most recently from 8654b96 to 87beb77 Compare March 28, 2021 01:06
@csymeonides-mf
Copy link
Contributor Author

@dbanty ready for review now, it would be great if we can get this in the next release!

@dbanty
Copy link
Collaborator

dbanty commented Mar 29, 2021

I think merging #361 made main conflict with your branch 😬 sorry about that. Please pull in the changes and resolve the conflicts when you get a chance.

@csymeonides-mf csymeonides-mf force-pushed the fix-allof-behaviour branch 2 times, most recently from 2dd8247 to 7ea91b6 Compare March 31, 2021 12:48
@csymeonides-mf
Copy link
Contributor Author

Ok this is much simpler now! That previous PR fixed a lot of my issues, and I decided not to bother with full-on merging of allOf schemas because it's a bit of an edge case. However I've kept the old branch in case we ever want to resurrect it.

I might have another PR for you later this week to fix an issue with multipart introduced by another recent PR... might be good to get them both in the next release if possible.

PS Thanks for this library, it's lovely :)

@csymeonides-mf
Copy link
Contributor Author

@dbanty Now rebased

Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job, thanks for fixing this!

@dbanty dbanty merged commit e7d52b6 into openapi-generators:main Apr 25, 2021
@dbanty dbanty added this to the 0.9.0 milestone Apr 25, 2021
@csymeonides-mf csymeonides-mf deleted the fix-allof-behaviour branch April 28, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants