Skip to content

feat: Allow allOf enums to be subsets of one another or their base types [#379, #423, #461]. Thanks @forest-benchling! #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 1, 2021

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Aug 1, 2021

Based on and closes #423. Closes #379.

forest-benchling and others added 13 commits August 1, 2021 16:53

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
This reverts commit 7561c01.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
…t coverage.
@codecov
Copy link

codecov bot commented Aug 1, 2021

Codecov Report

Merging #461 (864e0f8) into main (b857848) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #461   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         1564      1589   +25     
=========================================
+ Hits          1564      1589   +25     
Impacted Files Coverage Δ
..._python_client/parser/properties/model_property.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b857848...864e0f8. Read the comment docs.

@dbanty dbanty changed the title feat: Allow allOf enums to be subsets of one another or their base types [#421, #423]. Thanks @forest-benchling! feat: Allow allOf enums to be subsets of one another or their base types [#421, #423, #461]. Thanks @forest-benchling! Aug 1, 2021
@dbanty dbanty added this to the 0.10.2 milestone Aug 1, 2021
@dbanty dbanty enabled auto-merge (squash) August 1, 2021 23:27
@dbanty dbanty disabled auto-merge August 1, 2021 23:28
@dbanty dbanty changed the title feat: Allow allOf enums to be subsets of one another or their base types [#421, #423, #461]. Thanks @forest-benchling! feat: Allow allOf enums to be subsets of one another or their base types [#379, #423, #461]. Thanks @forest-benchling! Aug 1, 2021
@dbanty dbanty enabled auto-merge (squash) August 1, 2021 23:29
@dbanty dbanty disabled auto-merge August 1, 2021 23:31
@dbanty dbanty merged commit 0ca21aa into main Aug 1, 2021
@dbanty dbanty deleted the forest-allof-enum branch August 1, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support allOf of compatible types
2 participants