feat: Allow path parameters to be positional args [#429]. Thanks @tsotnikov! #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #464 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 1594 1614 +20
=========================================
+ Hits 1594 1614 +20
Continue to review full report at Codecov.
|
|
FYI @mtovts this will conflict with #458 once merged. I'll plan on waiting on yours first so I can handle the conflicts here. @forest-benchling this is based on another stale PR I've been neglecting, I could use a fresh set of eyes on it if you have a chance to take a look. |
forest-benchling
previously approved these changes
Aug 9, 2021
end_to_end_tests/golden-record/my_test_api_client/api/parameters/multiple_path_parameters.py
Show resolved
Hide resolved
OpenAPI Specification indicates that if parameter location is `path` the `required` property is REQUIRED and its value MUST be `true` Ref: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#parameter-object With this in mind, this PR: - Tighten the parsing by throwing an error for path parameters with required=false - Update the templates to pass the path parameters to the function as positional arguments instead of kwargs to improve usability
Also fix typo Co-authored-by: Dylan Anthony <[email protected]>
dbanty
force-pushed
the
path-parameters-args
branch
from
c2adba8 to
aa63b86
Compare
dbanty
force-pushed
the
path-parameters-args
branch
from
ff3211a to
f0fe788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #429 so I can rebase and resolve conflicts.