fix: Properly replace reserved words in class and module names [#475, #476]. Thanks @mtovts! #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #477 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 1579 1588 +9
=========================================
+ Hits 1579 1588 +9
Continue to review full report at Codecov.
|
… templates to rename with the same behavior as the parser.
dbanty
force-pushed
the
475-keyword-rename-failure
branch
from
f18901e to
7e4fd7d
Compare
|
Thank you for handling this so fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @mtovts I took a bit of a different approach to solving this, so this will close #475 and #476. Hopefully using the validated classes will prevent future mistakes of forgetting to clean things up.