hw/ssi/pnv_spi: Fixes Coverity CID 1558831

chalapathi-v · Michael Tokarev · commit 2a5eec6dd28c · 2024-11-05T18:59:01.000+03:00
In this commit the following coverity scan defect has been fixed CID 1558831: Resource leaks (RESOURCE_LEAK) Variable "rsp_payload" going out of scope leaks the storage it points to. Cc: qemu-stable@nongnu.org Fixes: Coverity CID 1558831 Signed-off-by: Chalapathi V <chalapathi.v@linux.ibm.com> Fixes: b4cb930 ("hw/ssi: Extend SPI model") [PMD: Rebased on previous commit (returning earlier)] Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Signed-off-by: Nicholas Piggin <npiggin@gmail.com> (cherry picked from commit 0313244) Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
diff --git a/hw/ssi/pnv_spi.c b/hw/ssi/pnv_spi.c
@@ -239,6 +239,7 @@ static void transfer(PnvSpi *s, PnvXferBuffer *payload)
         }
     }
     spi_response(s, s->N1_bits, rsp_payload);
+    pnv_spi_xfer_buffer_free(rsp_payload);
 }
 
 static inline uint8_t get_seq_index(PnvSpi *s)

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,7 @@ static void transfer(PnvSpi s, PnvXferBuffer payload)`
`239`	`239`	`}`
`240`	`240`	`}`
`241`	`241`	`spi_response(s, s->N1_bits, rsp_payload);`
	`242`	`+ pnv_spi_xfer_buffer_free(rsp_payload);`
`242`	`243`	`}`
`243`	`244`
`244`	`245`	`static inline uint8_t get_seq_index(PnvSpi *s)`