Update to React 19 (and get rid of some dependencies) #1269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's very little code we have to write. `use-resize-observer` was just used because of its ability to polyfill the feature. It was added in 2020 when support for ResizeObserver was still sparse. But by now all important browsers support it for many years already, so there is no need for a polyfill anymore. The reason why it is removed now is that it has no React 19 support yet, which I want to update to in upcoming commits. This dep was added in a998398
It only requires minimal code and gets rid of a dependency. Main problem with that dependency is that it did not support React 19 yet, which is the reason for this commit. The library had support for really old browsers, but since 2023, all browsers support blocking via `preventDefault()`, so no need to support other methods still (which are deprecated now anyway). This helper function will likely be moved to appkit.
This includes an update to appkit 0.5, using its `useUnloadBlocker`. This commit does not use any new React features, it just does the update so that everything works. Figuring out whether code can be improved by new features can be done later.
Member
|
I'm assuming this is safe and could be applied to all current (17.x+) versions of OC, but I'm thinking it should be in 18.x+ only given our release rules? Speaking of which, I see I/we haven't made the branches. Will try and get this done shortly. |
Member
Author
|
In the past couple years, Studio was only updated in the OC stable branch. Only security issues are worth backporting to the legacy branch. This PR should not have any user-visible changes, so it can be stable branch or develop. 🤷 |
This was referenced Nov 3, 2025
Member
Author
owi92
approved these changes
Nov 18, 2025
Contributor
owi92
left a comment
owi92
left a comment
There was a problem hiding this comment.
Code changes lgtm. I did some tests to confirm that everything is still working (desktop only, firefox).
This should be fine to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Studio to use React 19. See commit descriptions for additional information.
Test deployments: https://test.studio.opencast.org