Skip to content
This repository was archived by the owner on Oct 14, 2024. It is now read-only.

Commit

Permalink
refactor: code review
Browse files Browse the repository at this point in the history
  • Loading branch information
paralta committed Feb 15, 2024
1 parent 9297d2b commit a9f189e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -511,15 +511,15 @@ $(DIST_DIR)/CHANGELOG.md: $(ROOT_DIR)/cliff.toml bin/git-cliff | $(DIST_DIR)
.PHONY: multimod-verify
multimod-verify: bin/multimod
@echo "Validating versions.yaml file"
$(MULTIMOD) verify
$(MULTIMOD_BIN) verify

.PHONY: multimod-prerelease
multimod-prerelease: bin/multimod
$(MULTIMOD) prerelease --all-module-sets --skip-go-mod-tidy=true --commit-to-different-branch=false
$(MULTIMOD_BIN) prerelease --all-module-sets --skip-go-mod-tidy=true --commit-to-different-branch=false

.PHONY: multimod-push-tags
multimod-push-tags: bin/multimod
set -e; for tag in `$(MULTIMOD) tag --module-set-name vmclarity --commit-hash HEAD --print-tags | grep -v "Using" `; do \
set -e; for tag in `$(MULTIMOD_BIN) tag --module-set-name vmclarity --commit-hash HEAD --print-tags | grep -v "Using" `; do \
echo "pushing tag $${tag}"; \
git push origin $${tag}; \
done;
2 changes: 1 addition & 1 deletion RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ git checkout -b release/v0.7.0
```

* Modify the `versions.yaml` file to update the version for VMClarity's module-set. Keep in mind that the same version is applied to all modules.
```
```diff
vmclarity:
- version: v0.6.0
+ version: v0.7.0
Expand Down
1 change: 0 additions & 1 deletion makefile.d/20-tools.mk
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ bin/typos-$(TYPOS_VERSION): | $(BIN_DIR)

MULTIMOD_BIN := $(BIN_DIR)/multimod
MULTIMOD_REPO_DIR := $(BIN_DIR)/opentelemetry-go-build-tools
MULTIMOD := $(BIN_DIR)/multimod

bin/multimod:
@if [ ! -d $(MULTIMOD_REPO_DIR) ]; then git clone [email protected]:open-telemetry/opentelemetry-go-build-tools.git $(MULTIMOD_REPO_DIR); fi
Expand Down

0 comments on commit a9f189e

Please sign in to comment.