This repository was archived by the owner on Oct 14, 2024. It is now read-only.
docs: change asset-findings relationships rfc #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
This comment has been minimized.
This comment has been minimized.
ramizpolic
force-pushed
the
rfc/asset-groups
branch
from
a7298bb to
5e5bc0f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ramizpolic
changed the title
ramizpolic
changed the title
This comment has been minimized.
This comment has been minimized.
ramizpolic
force-pushed
the
rfc/asset-groups
branch
from
cfd3bc8 to
30f637a
Compare
ramizpolic
added
enhancement
ramizpolic
force-pushed
the
rfc/asset-groups
branch
from
30f637a to
1aa9f2a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ramizpolic
force-pushed
the
rfc/asset-groups
branch
from
26a2f19 to
8842d0c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ramizpolic
force-pushed
the
rfc/asset-groups
branch
2 times, most recently
from
11c7b9e to
3af02f6
Compare
This comment has been minimized.
This comment has been minimized.
ramizpolic
force-pushed
the
rfc/asset-groups
branch
from
0c4086b to
321f7d8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ramizpolic
changed the title
This comment has been minimized.
This comment has been minimized.
ramizpolic
force-pushed
the
rfc/asset-groups
branch
from
64c9cb7 to
343b824
Compare
|
Ready for review 🙅 |
This comment has been minimized.
This comment has been minimized.
paralta
previously approved these changes
Jan 30, 2024
ramizpolic
force-pushed
the
rfc/asset-groups
branch
from
0f92797 to
cd83d06
Compare
This comment has been minimized.
This comment has been minimized.
paralta
approved these changes
Jan 30, 2024
chrisgacsal
approved these changes
Feb 6, 2024
ramizpolic
force-pushed
the
rfc/asset-groups
branch
from
cd83d06 to
0b41b26
Compare
|
Hey! Your images are ready:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposes using many-to-many relationship between assets and findings to improve efficiency and achieve API consistency with the existing features.
This also enables feature-parity between VMClarity and KubeClarity findings.
Epic: #1041
Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[x] Documentation
[ ] Other (please describe)
Checklist