Skip to content
This repository was archived by the owner on Oct 14, 2024. It is now read-only.

refactor: code inspection improvements #1095

Merged
merged 4 commits into from
Jan 16, 2024
Merged

refactor: code inspection improvements #1095

merged 4 commits into from
Jan 16, 2024

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Jan 15, 2024

Description

Make a couple of improvements detected by code inspection:

  • fix variable collides with imported package name
  • type can be omitted
  • fix grammar
  • fix typos

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta requested review from a team as code owners January 15, 2024 17:07
Copy link

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1095-6f9b7d27ba7fdddc66c3a7d6fe85029737b3865a
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1095-6f9b7d27ba7fdddc66c3a7d6fe85029737b3865a
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1095-6f9b7d27ba7fdddc66c3a7d6fe85029737b3865a
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1095-6f9b7d27ba7fdddc66c3a7d6fe85029737b3865a
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1095-6f9b7d27ba7fdddc66c3a7d6fe85029737b3865a

Copy link
Member

@lgecse lgecse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ramizpolic ramizpolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for addressing this @paralta!

@paralta paralta added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit 9aa03a8 Jan 16, 2024
@paralta paralta deleted the code-inspection branch January 16, 2024 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants