This repository was archived by the owner on Oct 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69171b7
to
c28a212
Compare
This comment has been minimized.
This comment has been minimized.
c28a212
to
7da2051
Compare
This comment has been minimized.
This comment has been minimized.
4a70c83
to
694944a
Compare
694944a
to
0cb6aab
Compare
This comment has been minimized.
This comment has been minimized.
lgecse
previously approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @paralta for putting this RFC together.
ramizpolic
previously approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🚀
@ramizpolic @lgecse thank you so much for reviewing 😄 |
This comment has been minimized.
This comment has been minimized.
lgecse
previously approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
ramizpolic
previously approved these changes
Jan 19, 2024
chrisgacsal
reviewed
Jan 23, 2024
chrisgacsal
reviewed
Jan 23, 2024
This comment has been minimized.
This comment has been minimized.
eb20c86
to
affd284
Compare
This comment has been minimized.
This comment has been minimized.
affd284
to
cf7dd57
Compare
Hey! Your images are ready:
|
chrisgacsal
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job @paralta!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add RFC to propose a new project structure which splits the main module into multiple modules to allow us to version modules separately and reduce dependencies.
Type of Change
[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[x] Documentation
[ ] Other (please describe)
Checklist