This repository was archived by the owner on Oct 14, 2024. It is now read-only.

feat: add docker bake #1111

Merged

akijakya merged 2 commits into main from add-docker-bake

Feb 5, 2024

Contributor

akijakya commented Jan 21, 2024 •

edited

Loading

Description

Added Docker Bake to streamline docker builds, also modified the Makefile use bake for building and pushing images to the repository.

Modifying the CI will come in another PR.

Build time remained the same, but using Docker Bake comes with some advantages:

modularity 🧱

from now on Dockerfiles can exist in any place, number, or name within the repo (or even remote URLs can be used); they can be referred to properly in docker-bake.hcl with the context and dockerfile fields
multiple images can be built at once via target groups

tidiness ✨

Makefile is a bit cleaner now by not having to specify the same build commands per each image

Fixes #1085

Type of Change

[ ] Bug Fix
[X] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

I have read the contributing guidelines
Existing issues have been referenced (where applicable)
I have verified this change is not present in other open pull requests
Functionality is documented
All code style checks pass
New code contribution is covered by automated tests
All new and existing tests pass

akijakya added docker github actions github_actions ci labels

akijakya self-assigned this

akijakya requested a review from a team as a code owner

January 21, 2024 14:01

akijakya force-pushed the add-docker-bake branch 3 times, most recently from 75007c6 to bfa98a4 Compare

January 21, 2024 15:44

This comment has been minimized.

Sign in to view

akijakya force-pushed the add-docker-bake branch from bfa98a4 to 77c8810 Compare

January 21, 2024 16:00

This comment has been minimized.

Sign in to view

akijakya force-pushed the add-docker-bake branch from 77c8810 to f71e8a8 Compare

January 21, 2024 21:55

This comment has been minimized.

Sign in to view

akijakya force-pushed the add-docker-bake branch 2 times, most recently from 99e8ded to 333b285 Compare

January 21, 2024 23:55

This comment has been minimized.

Sign in to view

akijakya force-pushed the add-docker-bake branch from 333b285 to be50d64 Compare

January 22, 2024 00:13

This comment has been minimized.

Sign in to view

akijakya force-pushed the add-docker-bake branch from be50d64 to df2dcb9 Compare

January 22, 2024 08:13

This comment has been minimized.

Sign in to view

akijakya force-pushed the add-docker-bake branch from df2dcb9 to c1ec1f4 Compare

January 22, 2024 08:32

This comment has been minimized.

Sign in to view

akijakya marked this pull request as draft

January 22, 2024 09:33

akijakya force-pushed the add-docker-bake branch from c1ec1f4 to 1011bee Compare

January 22, 2024 13:09

This comment has been minimized.

Sign in to view

akijakya force-pushed the add-docker-bake branch from 1011bee to 1f5ab26 Compare

January 22, 2024 14:00

This comment has been minimized.

Sign in to view

akijakya force-pushed the add-docker-bake branch 2 times, most recently from da42bee to dacb6dd Compare

January 22, 2024 16:45

This comment has been minimized.

Sign in to view

akijakya force-pushed the add-docker-bake branch 3 times, most recently from 64b55bd to b1d7dde Compare

January 25, 2024 15:47

This comment has been minimized.

Sign in to view

akijakya force-pushed the add-docker-bake branch from b1d7dde to ab1e200 Compare

January 25, 2024 16:12

This comment has been minimized.

Sign in to view

akijakya marked this pull request as ready for review

January 25, 2024 20:38

ramizpolic suggested changes

View reviewed changes

docker-bake.hcl Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

.github/workflows/build-and-push-component.yaml Outdated Show resolved Hide resolved

.github/workflows/build-and-push-component.yaml Outdated Show resolved Hide resolved

.github/workflows/build-and-push-component.yaml Outdated Show resolved Hide resolved

.github/workflows/build-and-push-component.yaml Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

docker-bake.hcl Outdated Show resolved Hide resolved

docker-bake.hcl Show resolved Hide resolved

akijakya force-pushed the add-docker-bake branch 4 times, most recently from d913f9f to fc81bfe Compare

February 2, 2024 15:23

This comment has been minimized.

Sign in to view

chrisgacsal suggested changes

View reviewed changes

Makefile Outdated Show resolved Hide resolved

docker-bake.hcl Outdated Show resolved Hide resolved

docker-bake.hcl Outdated Show resolved Hide resolved

docker-bake.hcl Outdated Show resolved Hide resolved

docker-bake.hcl Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved


          feat: add docker bake file to streamline builds

3eff569

Signed-off-by: András Jáky <[email protected]>

akijakya force-pushed the add-docker-bake branch from fc81bfe to 4980331 Compare

February 5, 2024 10:16

This comment has been minimized.

Sign in to view


          refactor: modify Makefile to use docker bake

63d39ad

Signed-off-by: András Jáky <[email protected]>

akijakya force-pushed the add-docker-bake branch from 4980331 to 63d39ad Compare

February 5, 2024 13:32

github-actions bot commented Feb 5, 2024

Hey!

Your images are ready:

ghcr.io/openclarity/vmclarity-apiserver-dev:pr1111-17f57b07d5680e8131a268ae5662515151b8c3c2
ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1111-17f57b07d5680e8131a268ae5662515151b8c3c2
ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1111-17f57b07d5680e8131a268ae5662515151b8c3c2
ghcr.io/openclarity/vmclarity-ui-dev:pr1111-17f57b07d5680e8131a268ae5662515151b8c3c2
ghcr.io/openclarity/vmclarity-cli-dev:pr1111-17f57b07d5680e8131a268ae5662515151b8c3c2
ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1111-17f57b07d5680e8131a268ae5662515151b8c3c2

ramizpolic approved these changes

View reviewed changes

Member

ramizpolic left a comment

lgtm, tested make & bake and it works properly now, thanks @akijakya!

chrisgacsal approved these changes

View reviewed changes

Contributor

chrisgacsal left a comment

LGTM!

akijakya added this pull request to the merge queue

akijakya removed github actions github_actions ci labels

Merged via the queue into main with commit ccdfd29

37 checks passed

akijakya deleted the add-docker-bake branch

February 5, 2024 15:24

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docker