This repository was archived by the owner on Oct 14, 2024. It is now read-only.

refactor(api): create new api client, server and types modules #1147

Merged

paralta merged 8 commits into main from multiple-go-modules-api

Feb 1, 2024

Contributor

paralta commented Feb 1, 2024

Description

https://github.com/openclarity/vmclarity/blob/main/rfc/multiple-go-modules.md

Create new api/client, api/server and api/types modules

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

I have read the contributing guidelines
Existing issues have been referenced (where applicable)
I have verified this change is not present in other open pull requests
Functionality is documented
All code style checks pass
New code contribution is covered by automated tests
All new and existing tests pass

paralta requested a review from a team as a code owner

February 1, 2024 08:26

paralta marked this pull request as draft

February 1, 2024 08:30

This comment has been minimized.

Sign in to view

paralta marked this pull request as ready for review

February 1, 2024 09:08

paralta force-pushed the multiple-go-modules-api branch from 046ad71 to 7744b1f Compare

February 1, 2024 09:13

paralta self-assigned this

paralta added enhancement component:api labels

This comment has been minimized.

Sign in to view

chrisgacsal reviewed

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

paralta force-pushed the multiple-go-modules-api branch from 7744b1f to 40fc124 Compare

February 1, 2024 10:17

chrisgacsal reviewed

View reviewed changes

api/server/pkg/database/gorm/asset.go Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

chrisgacsal reviewed

View reviewed changes

Makefile Outdated Show resolved Hide resolved

paralta force-pushed the multiple-go-modules-api branch from 2f76a6c to 54a38e2 Compare

February 1, 2024 10:29

This comment has been minimized.

Sign in to view

chrisgacsal reviewed

View reviewed changes

api/client/client.go Show resolved Hide resolved

paralta force-pushed the multiple-go-modules-api branch from a6eb21a to a1bdd63 Compare

February 1, 2024 11:19

This comment has been minimized.

Sign in to view

paralta requested a review from chrisgacsal

February 1, 2024 13:07

paralta force-pushed the multiple-go-modules-api branch from a1bdd63 to 92f66be Compare

February 1, 2024 13:56

This comment has been minimized.

Sign in to view

paralta added 8 commits

February 1, 2024 16:02


          refactor(api): move apiserver and backendclient packages to api module

77102e7


          refactor(api): restructure

f5390ec


          refactor(api): modify code to use new paths

30b6c7c


          refactor(api): init and generate code per module

9ae94d0


          refactor(api): fix go version file path

3f019bd


          refactor(api): add missing licenses

7add096


          refactor(api): code review

abd89d2


          refactor(api): copy PointerTo to api types

58166f4

paralta force-pushed the multiple-go-modules-api branch from 92f66be to 58166f4 Compare

February 1, 2024 16:06

github-actions bot commented Feb 1, 2024

Hey!

Your images are ready:

ghcr.io/openclarity/vmclarity-apiserver-dev:pr1147-f4e31b38ccfc8363d49f3a379cee45ab9a00cbe7
ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1147-f4e31b38ccfc8363d49f3a379cee45ab9a00cbe7
ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1147-f4e31b38ccfc8363d49f3a379cee45ab9a00cbe7
ghcr.io/openclarity/vmclarity-ui-dev:pr1147-f4e31b38ccfc8363d49f3a379cee45ab9a00cbe7
ghcr.io/openclarity/vmclarity-cli-dev:pr1147-f4e31b38ccfc8363d49f3a379cee45ab9a00cbe7

chrisgacsal approved these changes

View reviewed changes

Contributor

chrisgacsal left a comment

LGTM! Just a nit. Please be consistent when it comes to module aliases used in import section.

paralta added this pull request to the merge queue

Merged via the queue into main with commit 6e64537

33 checks passed

paralta deleted the multiple-go-modules-api branch

February 1, 2024 16:57

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

component:api enhancement