Skip to content
This repository was archived by the owner on Oct 14, 2024. It is now read-only.

refactor(cli): create cli module #1150

Merged
merged 6 commits into from
Feb 2, 2024
Merged

refactor(cli): create cli module #1150

merged 6 commits into from
Feb 2, 2024

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Feb 1, 2024

Description

https://github.com/openclarity/vmclarity/blob/main/rfc/multiple-go-modules.md

  • Create new cli module
  • Remove gorequest dependency
  • Move scanner test boot to cli module

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta requested a review from a team as a code owner February 1, 2024 17:59
@paralta paralta self-assigned this Feb 1, 2024
@paralta paralta added the enhancement New feature or request label Feb 1, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@paralta paralta force-pushed the multiple-go-modules-cli branch from b60ec63 to e94f60a Compare February 2, 2024 11:13
@paralta paralta force-pushed the multiple-go-modules-cli branch from e94f60a to 3359123 Compare February 2, 2024 11:19
@paralta paralta force-pushed the multiple-go-modules-cli branch from 3359123 to 64cd1a6 Compare February 2, 2024 11:20
@paralta paralta requested a review from chrisgacsal February 2, 2024 11:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 2, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1150-8e6fec51e1177312998d781829a54311753f17fd
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1150-8e6fec51e1177312998d781829a54311753f17fd
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1150-8e6fec51e1177312998d781829a54311753f17fd
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1150-8e6fec51e1177312998d781829a54311753f17fd
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1150-8e6fec51e1177312998d781829a54311753f17fd
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1150-8e6fec51e1177312998d781829a54311753f17fd

@paralta paralta added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 0b2edd7 Feb 2, 2024
37 checks passed
@paralta paralta deleted the multiple-go-modules-cli branch February 2, 2024 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@paralta paralta

Labels
enhancement New feature or request
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paralta @chrisgacsal