Skip to content
This repository was archived by the owner on Oct 14, 2024. It is now read-only.

refactor: split cr-discovery into multiple modules #1151

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Feb 1, 2024

Description

Split containerruntimediscovery into multiple modules based on the Multi-module RFC:

  • add containerruntimediscovery/client
  • add containerruntimediscovery/server
  • add containerruntimediscovery/types

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal changed the title refactor: split crt-discovery to multiple modules refactor: split cr-discovery into multiple modules Feb 1, 2024
@chrisgacsal chrisgacsal marked this pull request as ready for review February 1, 2024 18:40
@chrisgacsal chrisgacsal requested a review from a team as a code owner February 1, 2024 18:40
@chrisgacsal chrisgacsal self-assigned this Feb 1, 2024
@chrisgacsal chrisgacsal added enhancement New feature or request go Pull requests that update Go code labels Feb 1, 2024

This comment has been minimized.

Copy link

github-actions bot commented Feb 1, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1151-fd8b862da8c09f263fa0af6e9d002aec16fdf0ac
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1151-fd8b862da8c09f263fa0af6e9d002aec16fdf0ac
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1151-fd8b862da8c09f263fa0af6e9d002aec16fdf0ac
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1151-fd8b862da8c09f263fa0af6e9d002aec16fdf0ac
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1151-fd8b862da8c09f263fa0af6e9d002aec16fdf0ac
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1151-fd8b862da8c09f263fa0af6e9d002aec16fdf0ac

Copy link
Contributor

@paralta paralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chrisgacsal chrisgacsal added this pull request to the merge queue Feb 2, 2024
Merged via the queue into main with commit 5720986 Feb 2, 2024
37 checks passed
@chrisgacsal chrisgacsal deleted the mv-rt-discovery branch February 2, 2024 11:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants