Skip to content
This repository was archived by the owner on Oct 14, 2024. It is now read-only.

refactor: create orchestrator and provider modules #1155

Merged
merged 8 commits into from
Feb 6, 2024
Merged

refactor: create orchestrator and provider modules #1155

merged 8 commits into from
Feb 6, 2024

Conversation

paralta
Copy link
Contributor

@paralta paralta commented Feb 2, 2024 •
edited
Loading

Description

https://github.com/openclarity/vmclarity/blob/main/rfc/multiple-go-modules.md

  • Create new orchestrator, provider and installation modules
  • Remove main module
  • Move example_external_provider_plugin to provider/examples/external

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[x] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@paralta paralta added the enhancement New feature or request label Feb 2, 2024
@paralta paralta self-assigned this Feb 2, 2024
@paralta paralta requested a review from a team as a code owner February 2, 2024 12:35
@paralta paralta marked this pull request as draft February 2, 2024 12:53
@paralta paralta force-pushed the multiple-go-modules-orchestrator branch 13 times, most recently from 5ef447c to c1e487a Compare February 6, 2024 10:23
@paralta paralta marked this pull request as ready for review February 6, 2024 10:24
@paralta paralta force-pushed the multiple-go-modules-orchestrator branch from c1e487a to 6629e3a Compare February 6, 2024 10:30
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@paralta paralta force-pushed the multiple-go-modules-orchestrator branch from b4e9e13 to 4de1b80 Compare February 6, 2024 15:26
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@paralta paralta force-pushed the multiple-go-modules-orchestrator branch from b1f645a to 7a84d4c Compare February 6, 2024 16:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1155-4bb90c4e2ffdbb4755de7e27d90bb263aa6f3e5b
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1155-4bb90c4e2ffdbb4755de7e27d90bb263aa6f3e5b
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1155-4bb90c4e2ffdbb4755de7e27d90bb263aa6f3e5b
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1155-4bb90c4e2ffdbb4755de7e27d90bb263aa6f3e5b
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1155-4bb90c4e2ffdbb4755de7e27d90bb263aa6f3e5b
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1155-4bb90c4e2ffdbb4755de7e27d90bb263aa6f3e5b

chrisgacsal
chrisgacsal approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@chrisgacsal chrisgacsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@chrisgacsal chrisgacsal added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 13a5a7c Feb 6, 2024
37 checks passed
@chrisgacsal chrisgacsal deleted the multiple-go-modules-orchestrator branch February 6, 2024 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrisgacsal chrisgacsal chrisgacsal approved these changes

Assignees

@paralta paralta

Labels
enhancement New feature or request
Projects
OpenClarity
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paralta @chrisgacsal