This repository was archived by the owner on Oct 14, 2024. It is now read-only.
ci: make name for digest artifact unique #1156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
actions/download-artifact@v4
action used inmerge-and-push
job uses a pattern filter to find all the digest artifacts uploaded for a specific image in order to combine them into a multi-arch container image. However the current filter set for this action is incorrect as it could allow to fetch digests for images which has similar name as the filter pattern uses the image name as a key.So using the
digests-7755142612-vmclarity-ui-*
pattern also includes artifacts with namedigests-7755142612-vmclarity-ui-backend-*
which is not the desired behavior.This change fixes this issue by using the SHA256 hash of the image name in the generated
digest-cache-name
used for naming and filtering the artifacts for image digests. This way we can reduce the chance for naming collisions.Type of Change
[x] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist