Skip to content
This repository was archived by the owner on Oct 14, 2024. It is now read-only.

ci: verify go modules #1163

Merged
merged 2 commits into from
Feb 6, 2024
Merged

ci: verify go modules #1163

merged 2 commits into from
Feb 6, 2024

Conversation

chrisgacsal
Copy link
Contributor

@chrisgacsal chrisgacsal commented Feb 6, 2024

Description

Verify go modules by running the following commands:

  • make gomod-list: try to lists all the dependencies defined in go.mod files and returns with error if it finds discrepancies like missing replace statement
  • make gomod-tidy: updates go.mod and go.sum files in necessary
  • git status --porcelain: detects changes to tracked files make by previous commands

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[x] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@chrisgacsal chrisgacsal requested a review from a team as a code owner February 6, 2024 16:59
@chrisgacsal chrisgacsal self-assigned this Feb 6, 2024
@chrisgacsal chrisgacsal added the ci Continious Integration related PRs label Feb 6, 2024
paralta
paralta previously approved these changes Feb 6, 2024
@chrisgacsal chrisgacsal force-pushed the ci-verify-go-mod branch 2 times, most recently from 6fb9f4d to 02a56a7 Compare February 6, 2024 17:17
@chrisgacsal chrisgacsal requested a review from paralta February 6, 2024 17:17
@chrisgacsal chrisgacsal enabled auto-merge February 6, 2024 17:32
Copy link

github-actions bot commented Feb 6, 2024

Hey!

Your images are ready:

  • ghcr.io/openclarity/vmclarity-apiserver-dev:pr1163-47b315fa7e9c39bbb630193fb8ad9014f3bcc1b0
  • ghcr.io/openclarity/vmclarity-orchestrator-dev:pr1163-47b315fa7e9c39bbb630193fb8ad9014f3bcc1b0
  • ghcr.io/openclarity/vmclarity-ui-backend-dev:pr1163-47b315fa7e9c39bbb630193fb8ad9014f3bcc1b0
  • ghcr.io/openclarity/vmclarity-ui-dev:pr1163-47b315fa7e9c39bbb630193fb8ad9014f3bcc1b0
  • ghcr.io/openclarity/vmclarity-cli-dev:pr1163-47b315fa7e9c39bbb630193fb8ad9014f3bcc1b0
  • ghcr.io/openclarity/vmclarity-cr-discovery-server-dev:pr1163-47b315fa7e9c39bbb630193fb8ad9014f3bcc1b0

@chrisgacsal chrisgacsal added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 296e88e Feb 6, 2024
37 checks passed
@chrisgacsal chrisgacsal deleted the ci-verify-go-mod branch February 6, 2024 18:13
paralta pushed a commit that referenced this pull request Feb 7, 2024
* ci: verify go modules

* fix: missing replace in api/server/go.mod
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continious Integration related PRs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants