This repository was archived by the owner on Oct 14, 2024. It is now read-only.
refactor: extend misconfiguration API and UI models #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akijakya
changed the title
4 tasks
akijakya
force-pushed
the
extend-misconfiguration-model
branch
from
cc0f6e8 to
f6a9678
Compare
This comment has been minimized.
This comment has been minimized.
akijakya
force-pushed
the
extend-misconfiguration-model
branch
from
f6a9678 to
c3453d6
Compare
This comment has been minimized.
This comment has been minimized.
akijakya
force-pushed
the
extend-misconfiguration-model
branch
from
c3453d6 to
a3a851f
Compare
This comment has been minimized.
This comment has been minimized.
ramizpolic
changed the title
ramizpolic
changed the title
paralta
approved these changes
Feb 9, 2024
ramizpolic
force-pushed
the
extend-misconfiguration-model
branch
from
a3a851f to
833e725
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
ramizpolic
force-pushed
the
extend-misconfiguration-model
branch
from
833e725 to
04f8727
Compare
|
Hey! Your images are ready:
|
chrisgacsal
suggested changes
Feb 9, 2024
chrisgacsal
approved these changes
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #1124 epic, updated some of the fields of the Misconfiguration object so they are generic enough to be used by the CIS Docker scanner as well.
These fields got updated in the database and the UI as well.
Screenshot of the UI changes:
Type of Change
[ ] Bug Fix
[ ] New Feature
[X] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist