Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better unsqeezing #138

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Add better unsqeezing #138

merged 1 commit into from
Feb 15, 2024

Conversation

jacobbieker
Copy link
Member

Pull Request

Description

Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jacobbieker jacobbieker self-assigned this Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (966b26a) 56.98% compared to head (c570c93) 56.97%.
Report is 1 commits behind head on main.

Files Patch % Lines
pvnet/models/multimodal/site_encoders/encoders.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   56.98%   56.97%   -0.01%     
==========================================
  Files          28       28              
  Lines        1797     1799       +2     
==========================================
+ Hits         1024     1025       +1     
- Misses        773      774       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobbieker jacobbieker merged commit d07cfbf into main Feb 15, 2024
4 of 5 checks passed
@jacobbieker jacobbieker deleted the jacob/unsqeeze2 branch February 15, 2024 12:40
@peterdudfield
Copy link
Contributor

@all-contributors please add @jacobbieker for code

Copy link
Contributor

@peterdudfield

I've put up a pull request to add @jacobbieker! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants