removed 'BatchKey' from 'encoders.py' and replaced necessary parts with strings... #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
I just wanted to know that do you guys have any social discussion forums like "Discord Server" or "Slack Server", as i am new and i couldn't find any such forums for discussion rather than the GitHub Discussion forum, if i was provided with some then it would be really helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
As the issue stated to get rid of "BatchKey" from "encoders.py" i have successfully done that and as the issue also stated to replace necessary parts with string, i have done that also.
Fixes #
How Has This Been Tested?
In a very humble tone, i am just getting started and i think that no tests were required since it was a very small change, please help me out if i am wrong.
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: