Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "BatchKey" and fixed dependents #328 #330

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Removed "BatchKey" and fixed dependents #328 #330

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a0937ff
removed BtachKey and made necessary keys as type string
devojyotimisra Mar 1, 2025
4d5c370
removed BatchKey and fixed dependent parts
devojyotimisra Mar 1, 2025
258d24e
removed print statements
devojyotimisra Mar 1, 2025
3448813
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 1, 2025
069f7ab
added comments explaining code changes
devojyotimisra Mar 1, 2025
537ab34
Merge completed
devojyotimisra Mar 1, 2025
f352be0
added comments explaining code changes
devojyotimisra Mar 1, 2025
cf589f6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 1, 2025
5af7268
tried few things but reverted back to original
devojyotimisra Mar 2, 2025
2e7af41
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions pvnet/models/multimodal/site_encoders/encoders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import einops
import torch
from ocf_datapipes.batch import BatchKey
from torch import nn

from pvnet.models.multimodal.linear_networks.networks import ResFCNet2
Expand Down Expand Up @@ -75,13 +74,25 @@ def __init__(
)

def _calculate_attention(self, x):
gsp_ids = x[BatchKey.gsp_id].squeeze().int()
# added this for loop to correctly acess the enum object
i = 0
for key in x.keys():
if i == 17:
ans = key
i += 1
gsp_ids = x[ans].squeeze().int()
attention = self._attention_network(gsp_ids)
return attention

def _encode_value(self, x):
# Shape: [batch size, sequence length, PV site]
pv_site_seqs = x[BatchKey.pv].float()
# added this for loop to correctly acess the enum object
i = 0
for key in x.keys():
if i == 6:
ans = key
i += 1
pv_site_seqs = x[ans].float()
batch_size = pv_site_seqs.shape[0]

pv_site_seqs = pv_site_seqs.swapaxes(1, 2).flatten(0, 1)
Expand Down