Skip to content

Commit

Permalink
fix(ecsoperator): Use cluster-default log group (#14)
Browse files Browse the repository at this point in the history
  • Loading branch information
devsjc authored Mar 4, 2025
1 parent 51bf46b commit dc1f574
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/airflow_dags/plugins/operators/ecs_run_task_operator.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def setup_operator(self) -> EcsRegisterTaskDefinitionOperator:
the `secrets` key in the container definition to prevent exposure in
the task definition.
"""
_, region = self.cluster_region_tuple
cluster, region = self.cluster_region_tuple

return EcsRegisterTaskDefinitionOperator(
family=self.name,
Expand All @@ -114,9 +114,9 @@ def setup_operator(self) -> EcsRegisterTaskDefinitionOperator:
"logConfiguration": {
"logDriver": "awslogs",
"options": {
"awslogs-group": f"/aws/ecs/{self.name}",
"awslogs-group": f"/aws/ecs/{cluster}",
"awslogs-region": region,
"awslogs-stream-prefix": f"streaming/{self.name}",
"awslogs-stream-prefix": f"airflow/{self.name}",
},
},
}],
Expand Down Expand Up @@ -172,8 +172,8 @@ def run_task_operator(
overrides={"containerOverrides": [overrides_dict]},
launch_type="FARGATE",
network_configuration=networks_dict,
awslogs_group=f"/aws/ecs/{self.name}",
awslogs_stream_prefix=f"streaming/{self.name}",
awslogs_group=f"/aws/ecs/{cluster}",
awslogs_stream_prefix=f"airflow/{self.name}",
awslogs_region=region,
trigger_rule=trigger_rule,
on_failure_callback=on_failure_callback,
Expand Down

0 comments on commit dc1f574

Please sign in to comment.