fix(packaging): Correctly build package for versioning #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsjc
commented
Feb 10, 2025
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| # Get package version | |||
| try: | |||
| __version__ = version("cloudcasting_app") | |||
| __version__ = version("cloudcasting-app") | |||
There was a problem hiding this comment.
This is the crux of what was wrong before!
| WORKDIR /opt/app | ||
| COPY src /opt/app/src | ||
| COPY pyproject.toml /opt/app | ||
| COPY .git /opt/app/.git |
There was a problem hiding this comment.
I can never remember if you change WORKDIR do you then copy COPY src /src. I can never remember
There was a problem hiding this comment.
I tested the build and run locally so whatever I've done here has worked! I think you can do that if you don't use absolute paths, i.e.
WORKDIR /app
COPY src srcis equivalent to
WORKDIR /app
COPY src /app/srcI think? Either way, the above seems to work!
peterdudfield
approved these changes
Feb 10, 2025
| "torch>=2.3; sys_platform != 'darwin' or platform_machine != 'x86_64'", | ||
| "typer==0.15.1", | ||
| "xarray==2025.1.2", | ||
| "zarr==2.18.3", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Actually gets the version number correctly by specifying the project name as it occurs in
pyproject.tomlto pull the version, as opposed to the name of the package. Also pins torch according to the environment, and includes the version in the built vresion tag.