-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and rename united_kingdom.md to great_britain.md #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renamed to great_britain.md added 3 more datasets for the same
zakwatts
reviewed
Feb 18, 2025
zakwatts
reviewed
Feb 18, 2025
zakwatts
reviewed
Feb 18, 2025
zakwatts
reviewed
Feb 18, 2025
zakwatts
reviewed
Feb 18, 2025
zakwatts
requested changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting these changes. A couple of comments
zakwatts
reviewed
Feb 18, 2025
made all the necessary changes , pls view |
zakwatts
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames united_kingdom.md to great_britain.md and adds three more datasets related to Great Britain's electricity grid data. The additional datasets enhance the coverage of real-time, historical, and forecasted energy data, making the resource more comprehensive.
Fixes #13 #11
How Has This Been Tested?
The changes involve adding documentation and do not affect code functionality. However, the following checks were performed:
Verified all dataset links are accessible and working.
Ensured proper Markdown formatting for readability on GitHub.
Reviewed content to ensure consistency in structure and information.
Checklist:
My changes follow [OCF's coding style guidelines]
I have performed a self-review of my own changes.
I have made corresponding changes to the documentation.
I have checked my work for accuracy and consistency