Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename united_kingdom.md to great_britain.md #15

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

arzoo0511
Copy link
Contributor

Description
This PR renames united_kingdom.md to great_britain.md and adds three more datasets related to Great Britain's electricity grid data. The additional datasets enhance the coverage of real-time, historical, and forecasted energy data, making the resource more comprehensive.

Fixes #13 #11

How Has This Been Tested?
The changes involve adding documentation and do not affect code functionality. However, the following checks were performed:

Verified all dataset links are accessible and working.
Ensured proper Markdown formatting for readability on GitHub.
Reviewed content to ensure consistency in structure and information.

Checklist:
My changes follow [OCF's coding style guidelines]
I have performed a self-review of my own changes.
I have made corresponding changes to the documentation.
I have checked my work for accuracy and consistency

renamed to great_britain.md
added 3 more datasets for the same
@zakwatts
Copy link
Collaborator

Thanks for doing this, The formatting, seems quite off though from the original grid_templates.md file. would you be able to have this match that?

Screenshot 2025-02-18 at 10 31 02

Copy link
Collaborator

@zakwatts zakwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting these changes. A couple of comments

@arzoo0511
Copy link
Contributor Author

made all the necessary changes , pls view

Copy link
Collaborator

@zakwatts zakwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zakwatts zakwatts merged commit 17f3de0 into openclimatefix:main Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the current united_kingdom.md file to be great_britain.md
2 participants