fix(coordinate): Log warning on unsafe regional writes #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdudfield
approved these changes
Jan 7, 2025
| dim: len(getattr(self, dim)) // self.maximum_number_of_chunks_in_one_dim | ||
| if len(getattr(self, dim)) > self.maximum_number_of_chunks_in_one_dim else 1 | ||
| dim: len(getattr(self, dim)) // chunk_count_overrides.get(dim, 2) | ||
| if len(getattr(self, dim)) > 8 else 1 |
There was a problem hiding this comment.
I think if the size is 8 or under its probably fine to be in one chunk by default since that's pretty small anyway!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to my own comments on PR #214 I've made some changes.
Since chunking is an IO decision to do with the written data and not the read in data, the chunking is relevant only to the write_to_region and create_suitable_store functions. In order to enable for different chunking from the default for the repositories that require it due to the natire of their files, overrides can be set in the repository metadata.