Add latitude and longitude to UKV

[peterdudfield]

Pull Request

Description

Add lat and long to UKV.
This is tricky, and I wasn't sure the best way to do this.

A different way to do it, is we explict write to two new data variables, but I dint really want to do this, seemed like more work. I also admit, having the 'a' write mode is a bit dangerous

Should merge into #226, but could go straight to main

How Has This Been Tested?

• CI tests
• tested it locally (not the docker image)

Checklist:

• My code follows OCF's coding style guidelines
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings

[devsjc]

Does the downstream forecasting app actually use the 2D latitude and longitude anywhere?

[peterdudfield]

Does the downstream forecasting app actually use the 2D latitude and longitude anywhere?

Yea the app uses the latitude and longitude, to reproject onto the same grid that it was trained on.
https://github.com/openclimatefix/uk-pvnet-app/blob/main/pvnet_app/data/nwp.py#L52

[peterdudfield]

Does the downstream forecasting app actually use the 2D latitude and longitude anywhere?

Yea the app uses the latitude and longitude, to reproject onto the same grid that it was trained on. https://github.com/openclimatefix/uk-pvnet-app/blob/main/pvnet_app/data/nwp.py#L52

Perhaps I could check that grid first

[peterdudfield]

This is in pvnet_app

And this is in the nwp-consumer

[peterdudfield]

I think becasue x and y are just integers, I think its important to save the lat and lon here

[devsjc]

Thanks for looking. Does it do this for every input or just UKV?

[peterdudfield]

Thanks for looking. Does it do this for every input or just UKV?

just UKV