Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVNet Site Datapipe #267

Merged
merged 3 commits into from
Jan 19, 2024
Merged

PVNet Site Datapipe #267

merged 3 commits into from
Jan 19, 2024

Conversation

jacobbieker
Copy link
Member

Pull Request

Description

Datapipe for use with PVNet for site and regional (but not GSP) forecasting.

Fixes #

How Has This Been Tested?

Unit tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jacobbieker jacobbieker added the enhancement New feature or request label Jan 19, 2024
@jacobbieker jacobbieker self-assigned this Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 155 lines in your changes are missing coverage. Please review.

Comparison is base (e45f900) 78.20% compared to head (504ab27) 76.07%.
Report is 15 commits behind head on main.

Files Patch % Lines
ocf_datapipes/training/pvnet_site.py 0.00% 155 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
- Coverage   78.20%   76.07%   -2.13%     
==========================================
  Files         121      122       +1     
  Lines        5551     5706     +155     
==========================================
  Hits         4341     4341              
- Misses       1210     1365     +155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobbieker jacobbieker marked this pull request as ready for review January 19, 2024 15:35
@jacobbieker jacobbieker merged commit e562992 into main Jan 19, 2024
3 of 5 checks passed
@jacobbieker jacobbieker deleted the jacob/pvnet-site branch January 19, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant