Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trying to import OpenTopography #275

Merged
merged 4 commits into from
Feb 23, 2024
Merged

fix trying to import OpenTopography #275

merged 4 commits into from
Feb 23, 2024

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

optionl for not import openTopography

Helps with openclimatefix/india-forecast-app#12

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 76.33%. Comparing base (64ed0e0) to head (8d25def).

Files Patch % Lines
ocf_datapipes/training/common.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   76.36%   76.33%   -0.04%     
==========================================
  Files         122      122              
  Lines        5755     5760       +5     
==========================================
+ Hits         4395     4397       +2     
- Misses       1360     1363       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdudfield peterdudfield requested a review from dfulu February 23, 2024 14:42
@peterdudfield peterdudfield merged commit 4ae78d1 into main Feb 23, 2024
3 of 5 checks passed
@peterdudfield peterdudfield deleted the fix/top-import branch February 23, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants