Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill gsp values #374

Merged
merged 7 commits into from
Feb 10, 2025
Merged

Fill gsp values #374

merged 7 commits into from
Feb 10, 2025

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Feb 10, 2025

Pull Request

Description

Fill GSP value with zeros, so even if PVLive is down, it can still run

openclimatefix/uk-pvnet-app#179

Had to pin zarr<3, as other tests are failing. I would fix this, but we are moving strong over to ocf-data-sampler, so I dont think its right to put the effort in

How Has This Been Tested?

Ci tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from devsjc February 10, 2025 09:44
@peterdudfield peterdudfield merged commit 936376b into main Feb 10, 2025
3 checks passed
@peterdudfield peterdudfield deleted the fill-gsp-values branch February 10, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants