Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill gsp values #375

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fill gsp values #375

merged 2 commits into from
Feb 12, 2025

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Feb 12, 2025

Pull Request

Description

If GSP values can interpolate values, return zeros.
This is not ideal, but we are getting rid of this library, so its a stop gap.
Also note that Pnvet app doesnt use these values, its just the pipeline for all the satellite and nwp data that does.

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.83%. Comparing base (6bab08b) to head (c77eebd).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
ocf_datapipes/load/gsp/database.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   78.36%   77.83%   -0.53%     
==========================================
  Files         126      127       +1     
  Lines        5962     6005      +43     
==========================================
+ Hits         4672     4674       +2     
- Misses       1290     1331      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdudfield peterdudfield merged commit b589440 into main Feb 12, 2025
5 of 7 checks passed
@peterdudfield peterdudfield deleted the fill-gsp-values branch February 12, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants