Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add china flag #239

Closed
wants to merge 1 commit into from
Closed

add china flag #239

wants to merge 1 commit into from

Conversation

zakwatts
Copy link
Contributor

Testing if creating PR after half past lets tests pass, based on some suspicious from testing locally.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.01%. Comparing base (5093843) to head (0a51b40).
Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   61.76%   68.01%   +6.25%     
==========================================
  Files          25       27       +2     
  Lines        1020     1085      +65     
==========================================
+ Hits          630      738     +108     
+ Misses        390      347      -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zakwatts
Copy link
Contributor Author

Update test to fix issue in #224 #238

@zakwatts
Copy link
Contributor Author

merged in #238

@zakwatts zakwatts closed this Jan 24, 2025
@zakwatts zakwatts deleted the china_flag_test branch January 24, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant