Mock calls to Open-Meteo API

[listopadiya]

Pull Request

Description

While executing unit tests in scope of github testing workflow, some requests to Open-Meteo API take a lot of time, and then fall with timeout (probably due to large timespans or authorization issues). It is considered to be not a good practice at all - to do network requests inside of unit tests. In scope of this fix, calls to Open-Meteo API are mocked with a fixture, which leads to smaller test execution time.

It was needed to do changes in quartz_solar_forecast/data.py and quartz_solar_forecast/forecasts/v2.py, so that they both use a wrapper from quartz_solar_forecast/weather/open_meteo.py, which made it possible to mock data requesting-related method. Also it allowed to avoid some of the code duplication.

Fixes #231

How Has This Been Tested?

Workflow tests job for unit tests succeeds in fork branch, test execution time is about 3 minutes now.

Coverage changed slightly (59%->58%), seems to be due to amount of codelines decreasing 🙂

Job for integration tests is failing, but I guess it wasn't working already.

• Yes

Checklist:

• My code follows OCF's coding style guidelines
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation - not sure if those needed
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings

[listopadiya]

Not sure if this repo is still alive... But just in case if it is, and it wasn't clear - this PR is ready for review.

[peterdudfield]

Hey @listopadiya thanks for this. Sorry i will review now

[peterdudfield]

There's quite a few changes here. I wonder if you could simplify some of these.

Could the mock test be aded without the other changes?

[peterdudfield]

Hi @listopadiya , would you be ok to resolve conflicts?