Integration Test fixes - #314
Conversation
|
@peterdudfield, there are two Parquet folders: 30_minutely and 5_minutely. Do you want me to create two separate test cases for them, or should we handle it via a single test with an argument to choose the folder? |
|
one single test, with an arguement sounded good |
|
@peterdudfield |
|
hey @yuvraajnarula did you manage to get the test passing? |
|
Here are my logs. Do u need a |
|
@peterdudfield any updates? |
| @@ -0,0 +1,9 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
And can this test be removed?
Or what does this do?
There was a problem hiding this comment.
It shouldnt be in conftest.py
There was a problem hiding this comment.
so should this contain the pytest_addoption and pytest_generate_tests hooks that enable the --foldername command-line option, not an actual test function?
There was a problem hiding this comment.
I have commented down the previous implementation and worked around pytest_addoption and pytest_generate_tests. So sorry for my confusion. Let me know if this is more cleaner and suitable for the PR.

Pull Request
Description
These changes fix multiple errors observed in unit tests and improve PV data handling:
Issues fixed:
pv.netcdffile in the repo.KeyError: 'kwp'ValueError: You are trying to merge on datetime64[ns] and datetime64[ns, UTC] columnsKeyError: 'generation_wh'Improvements in
get_pv_metadataandget_pv_truth:Column fixes:
kWp→capacityfor consistent naming.kwpcase issues.get_pv_metadata:pv_id.latitude,longitude,capacity).get_pv_truth:ss_idanddatetime_GMT.generation_Wh) to prevent KeyError.These changes improve test reliability and performance when working with PV datasets.
Fixes #292
How Has This Been Tested?
get_pv_metadataandget_pv_truthpass successfully.Checklist