Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Warnings #152

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

rahul-maurya11b
Copy link
Contributor

@rahul-maurya11b rahul-maurya11b commented Mar 24, 2024

Pull Request

Fixes #
changes are done based on the warning suggestion.
it fixes the warnings of Pydantic depreciation
as discussed in #125 other warnings now exists are related to dependencies or import

How Has This Been Tested?

Manually running pytest

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

move the pv_site_api in test and pydantic.py in tests folder then run pytest.

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield changed the base branch from main to external-pr March 25, 2024 07:38
@peterdudfield peterdudfield merged commit ef4d8db into openclimatefix:external-pr Mar 25, 2024
@peterdudfield
Copy link
Contributor

Ah it failed due to code linting, would you be able to fix them. I think you can run make format or make lint to fix and check them. When this is done, can you make a new PR?

@rahul-maurya11b
Copy link
Contributor Author

Sure sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants