Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete site #177

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Conversation

BraunRudolf
Copy link
Contributor

Pull Request

Description

Add route where user can delete site

  • check if user has access to site
  • deletion is handled by pv_datamodel.write.user_and_site.delete_site this wasn't validated again

Fixes #141

How Has This Been Tested?

Unit-Test implemented

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Signed-off-by: Rudolf Braun <[email protected]>
Signed-off-by: Rudolf Braun <[email protected]>
Signed-off-by: Rudolf Braun <[email protected]>
Signed-off-by: Rudolf Braun <[email protected]>
Signed-off-by: Rudolf Braun <[email protected]>
Signed-off-by: Rudolf Braun <[email protected]>
@BraunRudolf BraunRudolf marked this pull request as ready for review June 26, 2024 19:50
@peterdudfield peterdudfield reopened this Jun 27, 2024
@peterdudfield peterdudfield merged commit 173b155 into openclimatefix:main Jun 27, 2024
1 check passed
@BraunRudolf BraunRudolf deleted the add_delete_site branch June 27, 2024 13:02
@peterdudfield
Copy link
Contributor

@all-contributors please add @BraunRudolf for code

Copy link
Contributor

@peterdudfield

I've put up a pull request to add @BraunRudolf! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add method to delete site
2 participants