Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #201

Merged
merged 13 commits into from
Oct 28, 2024
Merged

Development #201

merged 13 commits into from
Oct 28, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Oct 28, 2024

Pull Request

Description

  • update cache, and update docs

#200
#186

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Sigma-Verma and others added 10 commits September 23, 2024 23:29
Made cache removal safer by using a lock to avoid repeated checks
added old-cache-check for skipping unnecessary processing, improving response time
minor indent fixes
Update documentation to say PV data should be in kilowatts
Clarify PV Data Submission#196
Copy link

sentry-io bot commented Oct 28, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: pv_site_api/cache.py

Function Unhandled Issue
remove_old_cache RuntimeError: dictionary changed size during iteration /sites/{site_uuid}/pv_fo...
Event Count: 12
remove_old_cache RuntimeError: dictionary changed size during iteration /sites/pv_fo...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@peterdudfield
Copy link
Contributor Author

@all-contributors please add @Sigma-Verma for code

Copy link
Contributor

@peterdudfield

I've put up a pull request to add @Sigma-Verma! 🎉

…a-Verma

docs: add Sigma-Verma as a contributor for code
@peterdudfield peterdudfield merged commit 2f16066 into main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants