Amend docker setup for local fake data #390
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 94.20% 92.74% -1.47%
==========================================
Files 23 23
Lines 1415 1447 +32
==========================================
+ Hits 1333 1342 +9
- Misses 82 105 +23 ☔ View full report in Codecov by Sentry. |
|
|
||
| # Check database has been created, if not run the migrations | ||
| if not inspect(connection.engine).has_table("status"): | ||
| connection.create_all() |
There was a problem hiding this comment.
Could you add a warning print statement in here, saying I'm making SQL tables. Just so its clear for people
There was a problem hiding this comment.
If it's about to create ~10+ tables, so any print statements here will be gone immediately... if we actually want to warn the user before creating the tables, we'd have to change how this is set up
|
Can you update PR description please? |
|
You could write a unit test for your new function of |
Pull Request
Description
Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: