A fix for undetected count overflows #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged, and then edited the file for grammar, and pushed that. I didn't review the code to see if it actually does what you say it does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1325.
I added comments both at a function comment block and inside the function.
naturally, they overlap.
@linas,
As always, please feel free to modify my wording, or propose modified wording and I will resend the PR.
While inspecting the current code, I noted that there is a comment-rot in the function comments of
do_parse()asnull_countis no longer an explicit parameter. I left it as it is because the intention is still clear.(I also noted a yet more speedup potential, that I will inspect after I send the "amy" and tokenizer fixes.)