Skip to content

Fix: Restore MATLAB Module Compilation for OpenCV 4.x #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/matlab/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ ocv_add_module(matlab BINDINGS
opencv_calib opencv_calib3d
opencv_stitching opencv_superres
opencv_xfeatures2d
opencv_optflow
opencv_xphoto
)

# get the commit information
Expand Down Expand Up @@ -156,6 +158,8 @@ endforeach()
# add extra headers by hand
list(APPEND opencv_extra_hdrs "core=${OPENCV_MODULE_opencv_core_LOCATION}/include/opencv2/core/base.hpp")
list(APPEND opencv_extra_hdrs "video=${OPENCV_MODULE_opencv_video_LOCATION}/include/opencv2/video/tracking.hpp")
list(APPEND opencv_extra_hdrs "optflow=${OPENCV_MODULE_opencv_optflow_LOCATION}/include/opencv2/optflow.hpp")


# pass the OPENCV_CXX_EXTRA_FLAGS through to the mex compiler
# remove the visibility modifiers, so the mex gateway is visible
Expand Down
10 changes: 8 additions & 2 deletions modules/matlab/generator/parse_tree.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import collections
import sys
if sys.version_info >= (3, 10):
import collections.abc
IterableType = collections.abc.Iterable
else:
import collections
IterableType = collections.Iterable
from textwrap import fill
from filters import *
try:
Expand Down Expand Up @@ -371,7 +377,7 @@ def todict(obj):
return obj
elif isinstance(obj, dict):
return dict((key, todict(val)) for key, val in obj.items())
elif isinstance(obj, collections.Iterable):
elif isinstance(obj, IterableType):
return [todict(val) for val in obj]
elif hasattr(obj, '__dict__'):
return todict(vars(obj))
Expand Down
32 changes: 30 additions & 2 deletions modules/matlab/include/opencv2/matlab/bridge.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,21 @@
#include <opencv2/photo.hpp>
#include <opencv2/stitching.hpp>
#include <opencv2/video.hpp>
#include <opencv2/optflow.hpp>
#include <opencv2/xphoto.hpp>

/* This 'using' line was added in order to fix the following Error.
* Failed to compile currentUIFramework:
* modules/matlab/src/currentUIFramework.cpp:
* In function void mexFunction(int, mxArray**, int, const mxArray**)
* error: string was not declared in this scope
* string retval; in line 41
*
* This error happens at the last stage of opencv build, when compiling the mex bindings
* TODO: This is NOT the optimal fix, and needs to be addressed
*/
using std::string;


namespace cv {
namespace bridge {
Expand Down Expand Up @@ -85,17 +100,21 @@ typedef cv::Ptr<AlignMTB> Ptr_AlignMTB;
typedef cv::Ptr<CalibrateDebevec> Ptr_CalibrateDebevec;
typedef cv::Ptr<CalibrateRobertson> Ptr_CalibrateRobertson;
typedef cv::Ptr<DenseOpticalFlow> Ptr_DenseOpticalFlow;
typedef cv::Ptr<DualTVL1OpticalFlow> Ptr_DualTVL1OpticalFlow;
typedef cv::Ptr<cv::optflow::DualTVL1OpticalFlow> Ptr_DualTVL1OpticalFlow;
typedef cv::Ptr<MergeDebevec> Ptr_MergeDebevec;
typedef cv::Ptr<MergeMertens> Ptr_MergeMertens;
typedef cv::Ptr<MergeRobertson> Ptr_MergeRobertson;
typedef cv::Ptr<Stitcher> Ptr_Stitcher;
typedef cv::Ptr<Tonemap> Ptr_Tonemap;
typedef cv::Ptr<TonemapDrago> Ptr_TonemapDrago;
typedef cv::Ptr<TonemapDurand> Ptr_TonemapDurand;
typedef cv::Ptr<cv::xphoto::TonemapDurand> Ptr_TonemapDurand;
typedef cv::Ptr<TonemapMantiuk> Ptr_TonemapMantiuk;
typedef cv::Ptr<TonemapReinhard> Ptr_TonemapReinhard;
typedef cv::Ptr<float> Ptr_float;
typedef cv::Ptr<cv::GeneralizedHoughBallard> Ptr_GeneralizedHoughBallard;
typedef cv::Ptr<cv::GeneralizedHoughGuil> Ptr_GeneralizedHoughGuil;



// ----------------------------------------------------------------------------
// PREDECLARATIONS
Expand Down Expand Up @@ -527,6 +546,15 @@ class Bridge {
Bridge& operator=(const Ptr_float& ) { return *this; }
Ptr_float toPtrFloat() { return Ptr_float(); }
operator Ptr_float() { return toPtrFloat(); }

// --------------------------- Ptr_GeneralizedHoughBallard --------------
Bridge& operator=(const Ptr_GeneralizedHoughBallard& obj) { return *this; }
operator Ptr_GeneralizedHoughBallard() { return Ptr_GeneralizedHoughBallard(); }

// --------------------------- Ptr_GeneralizedHoughGuil ----------------------
Bridge& operator=(const Ptr_GeneralizedHoughGuil& obj) { return *this; }
operator Ptr_GeneralizedHoughGuil() { return Ptr_GeneralizedHoughGuil(); }

}; // class Bridge


Expand Down
Loading