Add warpAffine and resizeDown APIs in FastCV Extension #3936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @asmorkalov, i think we don't need dummy PR for this |
asmorkalov
reviewed
May 19, 2025
| * | ||
| * @return Returns 0 if the transformation is valid. | ||
| */ | ||
| CV_EXPORTS_W void warpAffineROI(InputArray _src, const cv::Point2f& position, InputArray _affine, OutputArray _patch, Size patchSize); |
There was a problem hiding this comment.
Technically, the API is redundant. OpenCV cv::Mat has locateRoi method that may extract details of the original matrix, if roi is provided as a parameter. You can just handle the case in existing warpAffine.
| } | ||
| } | ||
|
|
||
| void warpAffine3Channel(InputArray _src, OutputArray _dst, InputArray _M, Size dsize, OutputArray _dstBorder) |
There was a problem hiding this comment.
Technically, you do not need extra API call. You can handle amount of channels in warpAffine in run time and select proper FastCV call.
Comment on lines
+31
to
+32
| CV_Assert(inv_scale_x > 0); | ||
| CV_Assert(inv_scale_y > 0); |
There was a problem hiding this comment.
The limitation is not documented in the function header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added warpAffine function to apply affine transformations to grayscale images using a 2x3 matrix.
Added warpAffine3Channel function to apply affine transformations to 3-channel RGB images with bicubic interpolation.
Added warpAffineROI function to warp a patch centered at a specified position in the input image using a 2x2 affine matrix.
Deprecated resizeDownBy2 and resizeDownBy4 functions.
Introduced resizeDown function to down-scale images using specified scaling factors or dimensions, supporting both single-channel (CV_8UC1) and two-channel (CV_8UC2) images.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.