Fixed division zero and unintentional bias in Otsu's threshold (CUDA)#4090
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Mar 30, 2026
Merged
Fixed division zero and unintentional bias in Otsu's threshold (CUDA)#4090asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
asmorkalov
approved these changes
Mar 30, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two bug fixes to the CUDA implementation of Otsu:
n_samples_aboveorn_samples_belowcould be zero. In that case we would do a zero divisionthreshold_sums[0]contains the full sum of the histogram is not true as it only contains the sum of bins above the threshold (0). I changedn_samplesto be a parameter, so we can usesrc.rows * src.colsinstead.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.