Skip to content

Fixed division zero and unintentional bias in Otsu's threshold (CUDA)#4090

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
troelsy:4.x
Mar 30, 2026
Merged

Fixed division zero and unintentional bias in Otsu's threshold (CUDA)#4090
asmorkalov merged 1 commit intoopencv:4.xfrom
troelsy:4.x

Conversation

@troelsy
Copy link
Copy Markdown
Contributor

@troelsy troelsy commented Mar 11, 2026

This PR contains two bug fixes to the CUDA implementation of Otsu:

  1. You could have a histogram, where n_samples_above or n_samples_below could be zero. In that case we would do a zero division
  2. Assuming threshold_sums[0] contains the full sum of the histogram is not true as it only contains the sum of bins above the threshold (0). I changed n_samples to be a parameter, so we can use src.rows * src.cols instead.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-requested a review March 30, 2026 07:54
@asmorkalov asmorkalov self-assigned this Mar 30, 2026
@asmorkalov asmorkalov merged commit 2ac61cd into opencv:4.x Mar 30, 2026
23 of 25 checks passed
@asmorkalov asmorkalov mentioned this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants