[surface_matching] Add binary save/load for PPF3DDetector#4096
Open
v5a wants to merge 2 commits intoopencv:4.xfrom
Open
[surface_matching] Add binary save/load for PPF3DDetector#4096v5a wants to merge 2 commits intoopencv:4.xfrom
v5a wants to merge 2 commits intoopencv:4.xfrom
Conversation
asmorkalov
reviewed
Mar 25, 2026
Author
|
Hi @asmorkalov, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements
saveModelandloadModelmethods forPPF3DDetectorto enable saving trained models to disk and reloading them later. This addresses the long‑standing missing functionality reported in #3353.Changes
saveModel(): writes all internal state (sampled point cloud, PPF matrix, hash nodes, hash table) to a custom binary file.loadModel(): reads back the binary file and reconstructs the detector state exactly.FileStoragebecause XML/YAML serialization is too slow for the large datasets typically processed by this module.Testing
parasaurolophus_6700.ply.trained_model.binand loaded it into a new detector instance.rs1_normals.ply.0.0, confirming perfect consistency.Related Issue
Closes #3353